Skip to content

chore(deps): update sharp to 0.35.3 via overrides - #504

Open
samanyugoyal2010 wants to merge 5 commits into
usemoss:mainfrom
samanyugoyal2010:cursor/update-sharp-0.35.3-2bfb
Open

chore(deps): update sharp to 0.35.3 via overrides#504
samanyugoyal2010 wants to merge 5 commits into
usemoss:mainfrom
samanyugoyal2010:cursor/update-sharp-0.35.3-2bfb

Conversation

@samanyugoyal2010

@samanyugoyal2010 samanyugoyal2010 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Pin sharp@0.35.3 in the four Next.js apps where it appears as a transitive optional dependency of next. Next 16.2.x still declares sharp@^0.34.5, so an override is required to pull in the latest release (0.35.3).

Fixes #471

Pull Request Checklist

Please ensure that your PR meets the following requirements:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation (if applicable).
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Review in cubic

Summary by CodeRabbit

  • Chores
    • Standardized the bundled image-processing component to version 0.35.3 across several applications.
    • Added a Node.js 20.9.0 or later requirement for supported projects.
    • Pinned CSS processing tooling to a consistent version where applicable.
    • Improved consistency and reliability of image handling and build setup during installation and builds.

Pin sharp@0.35.3 in the four Next.js apps where it appears as a
transitive optional dependency of next. Next 16.2.x still declares
sharp@^0.34.5, so an override is required to pull in the latest
release (0.35.3).

Fixes usemoss#471
@CLAassistant

CLAassistant commented Aug 1, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 50fc1607-7591-4392-81f5-010ec083f2ce

📥 Commits

Reviewing files that changed from the base of the PR and between 17aa1c4 and 2e80033.

⛔ Files ignored due to path filters (4)
  • apps/livekit-moss-vercel/agent-react/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • apps/moss-llamaindex/frontend/package-lock.json is excluded by !**/package-lock.json
  • apps/next-js/package-lock.json is excluded by !**/package-lock.json
  • examples/voice-agents/insurance-adjuster/ui/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • apps/livekit-moss-vercel/agent-react/package.json
  • apps/moss-llamaindex/frontend/package.json
  • apps/next-js/package.json

📝 Walkthrough

Walkthrough

The pull request updates four package manifests. Each manifest requires Node.js >=20.9.0 and pins sharp to 0.35.3. Three manifests pin postcss to 8.5.19; the insurance adjuster UI retains its existing postcss override.

Changes

Package runtime and dependency configuration

Layer / File(s) Summary
Set runtime and dependency requirements
apps/livekit-moss-vercel/agent-react/package.json, apps/moss-llamaindex/frontend/package.json, apps/next-js/package.json, examples/voice-agents/insurance-adjuster/ui/package.json
Each manifest adds the Node.js engine requirement >=20.9.0 and pins sharp to 0.35.3. The first three manifests pin postcss to 8.5.19; the insurance adjuster UI retains its existing postcss override.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ashvathsureshkumar

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The pull request also adds Node.js engine requirements and pins postcss, which are not covered by the linked sharp update issue. Remove the unrelated Node.js and postcss changes unless they are required and documented as part of this update.
Linked Issues check ❓ Inconclusive All four manifests add sharp 0.35.3, but lockfile refreshes cannot be verified because the lockfiles were excluded by path filters. Include the affected lockfiles in review or provide evidence that each lockfile was refreshed.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: updating sharp to version 0.35.3 through dependency overrides.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/livekit-moss-vercel/agent-react/package.json`:
- Around line 55-56: Add and commit the missing pnpm lockfiles for
apps/livekit-moss-vercel/agent-react/package.json,
apps/moss-llamaindex/frontend/package.json, apps/next-js/package.json, and
examples/voice-agents/insurance-adjuster/ui/package.json, ensuring dependencies
such as sharp@0.35.3 are captured consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 48b6df76-4f03-49d8-b570-ccb5a6a8fe9c

📥 Commits

Reviewing files that changed from the base of the PR and between de26a4b and 6046153.

⛔ Files ignored due to path filters (4)
  • apps/livekit-moss-vercel/agent-react/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • apps/moss-llamaindex/frontend/package-lock.json is excluded by !**/package-lock.json
  • apps/next-js/package-lock.json is excluded by !**/package-lock.json
  • examples/voice-agents/insurance-adjuster/ui/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • apps/livekit-moss-vercel/agent-react/package.json
  • apps/moss-llamaindex/frontend/package.json
  • apps/next-js/package.json
  • examples/voice-agents/insurance-adjuster/ui/package.json

Comment thread apps/livekit-moss-vercel/agent-react/package.json Outdated
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codex review

No issues found.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Re-trigger cubic

sharp@0.35.3 raises the minimum Node version from 18.x to 20.9.0.
Add engines constraints to the four affected Next.js apps so deploy
and local runtimes align with the overridden dependency.

Addresses review feedback on usemoss#504.
cursor Bot pushed a commit to samanyugoyal2010/moss that referenced this pull request Aug 1, 2026
sharp@0.35.3 raises the minimum Node version from 18.x to 20.9.0.
Add engines constraints to the four affected Next.js apps so deploy
and local runtimes align with the overridden dependency.

Addresses review feedback on usemoss#504.

Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/update-sharp-0.35.3-2bfb branch from 615656d to 40e4440 Compare August 1, 2026 01:44
@samanyugoyal2010

Copy link
Copy Markdown
Contributor Author

@HarshaNalluru @r4ghu @ashvathsureshkumar this PR can be approved

Comment thread apps/next-js/package.json Outdated
Use an exact postcss version in overrides instead of ^8.5.19,
matching the repo convention and addressing review feedback on
usemoss#504.
cursor Bot pushed a commit to samanyugoyal2010/moss that referenced this pull request Aug 1, 2026
Use an exact postcss version in overrides instead of ^8.5.19,
matching the repo convention and addressing review feedback on
usemoss#504.

Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/livekit-moss-vercel/agent-react/package.json`:
- Around line 58-59: Regenerate the lockfile for
apps/livekit-moss-vercel/agent-react/package.json lines 58-59 so the postcss
override resolves exactly to 8.5.19 rather than ^8.5.19. Add or refresh the
application lockfile for apps/moss-llamaindex/frontend/package.json lines 37-38
and verify it resolves postcss to 8.5.19 and sharp to 0.35.3.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 824a374d-d16b-429d-b5b6-d73e4591518d

📥 Commits

Reviewing files that changed from the base of the PR and between 40e4440 and 17aa1c4.

📒 Files selected for processing (3)
  • apps/livekit-moss-vercel/agent-react/package.json
  • apps/moss-llamaindex/frontend/package.json
  • apps/next-js/package.json

Comment thread apps/livekit-moss-vercel/agent-react/package.json
Regenerate pnpm-lock.yaml so overrides.postcss matches package.json
(8.5.19, not ^8.5.19). Refresh npm lockfiles to include engines
metadata for moss-llamaindex and next-js.

Addresses review feedback on usemoss#504.
cursor Bot pushed a commit to samanyugoyal2010/moss that referenced this pull request Aug 1, 2026
Regenerate pnpm-lock.yaml so overrides.postcss matches package.json
(8.5.19, not ^8.5.19). Refresh npm lockfiles to include engines
metadata for moss-llamaindex and next-js.

Addresses review feedback on usemoss#504.

Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
Regenerate package-lock.json so packages[""].engines matches the
package.json node >=20.9.0 constraint, consistent with the other
npm workspaces in this PR.

Addresses review feedback on usemoss#504.
cursor Bot pushed a commit to samanyugoyal2010/moss that referenced this pull request Aug 1, 2026
Regenerate package-lock.json so packages[""].engines matches the
package.json node >=20.9.0 constraint, consistent with the other
npm workspaces in this PR.

Addresses review feedback on usemoss#504.

Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/update-sharp-0.35.3-2bfb branch from fc48f22 to 2e80033 Compare August 1, 2026 22:54
@samanyugoyal2010

Copy link
Copy Markdown
Contributor Author

@HarshaNalluru @r4ghu @ashvathsureshkumar Merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update sharp to the latest release

3 participants