chore(deps): update sharp to 0.35.3 via overrides - #504
Conversation
Pin sharp@0.35.3 in the four Next.js apps where it appears as a transitive optional dependency of next. Next 16.2.x still declares sharp@^0.34.5, so an override is required to pull in the latest release (0.35.3). Fixes usemoss#471
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request updates four package manifests. Each manifest requires Node.js ChangesPackage runtime and dependency configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/livekit-moss-vercel/agent-react/package.json`:
- Around line 55-56: Add and commit the missing pnpm lockfiles for
apps/livekit-moss-vercel/agent-react/package.json,
apps/moss-llamaindex/frontend/package.json, apps/next-js/package.json, and
examples/voice-agents/insurance-adjuster/ui/package.json, ensuring dependencies
such as sharp@0.35.3 are captured consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 48b6df76-4f03-49d8-b570-ccb5a6a8fe9c
⛔ Files ignored due to path filters (4)
apps/livekit-moss-vercel/agent-react/pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlapps/moss-llamaindex/frontend/package-lock.jsonis excluded by!**/package-lock.jsonapps/next-js/package-lock.jsonis excluded by!**/package-lock.jsonexamples/voice-agents/insurance-adjuster/ui/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
apps/livekit-moss-vercel/agent-react/package.jsonapps/moss-llamaindex/frontend/package.jsonapps/next-js/package.jsonexamples/voice-agents/insurance-adjuster/ui/package.json
Codex reviewNo issues found. |
sharp@0.35.3 raises the minimum Node version from 18.x to 20.9.0. Add engines constraints to the four affected Next.js apps so deploy and local runtimes align with the overridden dependency. Addresses review feedback on usemoss#504.
sharp@0.35.3 raises the minimum Node version from 18.x to 20.9.0. Add engines constraints to the four affected Next.js apps so deploy and local runtimes align with the overridden dependency. Addresses review feedback on usemoss#504. Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
615656d to
40e4440
Compare
|
@HarshaNalluru @r4ghu @ashvathsureshkumar this PR can be approved |
Use an exact postcss version in overrides instead of ^8.5.19, matching the repo convention and addressing review feedback on usemoss#504.
Use an exact postcss version in overrides instead of ^8.5.19, matching the repo convention and addressing review feedback on usemoss#504. Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/livekit-moss-vercel/agent-react/package.json`:
- Around line 58-59: Regenerate the lockfile for
apps/livekit-moss-vercel/agent-react/package.json lines 58-59 so the postcss
override resolves exactly to 8.5.19 rather than ^8.5.19. Add or refresh the
application lockfile for apps/moss-llamaindex/frontend/package.json lines 37-38
and verify it resolves postcss to 8.5.19 and sharp to 0.35.3.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 824a374d-d16b-429d-b5b6-d73e4591518d
📒 Files selected for processing (3)
apps/livekit-moss-vercel/agent-react/package.jsonapps/moss-llamaindex/frontend/package.jsonapps/next-js/package.json
Regenerate pnpm-lock.yaml so overrides.postcss matches package.json (8.5.19, not ^8.5.19). Refresh npm lockfiles to include engines metadata for moss-llamaindex and next-js. Addresses review feedback on usemoss#504.
Regenerate pnpm-lock.yaml so overrides.postcss matches package.json (8.5.19, not ^8.5.19). Refresh npm lockfiles to include engines metadata for moss-llamaindex and next-js. Addresses review feedback on usemoss#504. Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
Regenerate package-lock.json so packages[""].engines matches the package.json node >=20.9.0 constraint, consistent with the other npm workspaces in this PR. Addresses review feedback on usemoss#504.
Regenerate package-lock.json so packages[""].engines matches the package.json node >=20.9.0 constraint, consistent with the other npm workspaces in this PR. Addresses review feedback on usemoss#504. Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
fc48f22 to
2e80033
Compare
|
@HarshaNalluru @r4ghu @ashvathsureshkumar Merge this PR |
Pin sharp@0.35.3 in the four Next.js apps where it appears as a transitive optional dependency of next. Next 16.2.x still declares sharp@^0.34.5, so an override is required to pull in the latest release (0.35.3).
Fixes #471
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue number)
Type of Change
Summary by CodeRabbit